Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory regression when resolving large artifacts while computing checksums #11966

Closed
melix opened this issue Jan 22, 2020 · 0 comments · Fixed by #11969
Closed

Memory regression when resolving large artifacts while computing checksums #11966

melix opened this issue Jan 22, 2020 · 0 comments · Fixed by #11969
Assignees
@melix
Labels
a:bug in:dependency-management DO NOT USE
Milestone
6.1.1

Comments

@melix
Copy link
Contributor

melix commented Jan 22, 2020

Current behavior

The org.gradle.internal.hash.ChecksumHasher#hash(File) method loads whole files in memory, it doesn't have to.

This can cause out of memory issues during publication when hashing large artifacts (several hundreds of MBs).
@melix melix added this to the 6.2 RC1 milestone Jan 22, 2020
@melix melix self-assigned this Jan 22, 2020
@melix melix added the in:dependency-management DO NOT USE label Jan 22, 2020
@melix melix mentioned this issue Jan 22, 2020
Merged
@big-guy big-guy modified the milestones: 6.2 RC1, 6.1.1 Jan 24, 2020
@big-guy big-guy changed the title Don't load the whole file in memory when computing checksums Memory regression when resolving large artifacts while computing checksums Jan 24, 2020
ausatiy added a commit to JetBrains/kotlin that referenced this issue Mar 11, 2021
@ausatiy
Update Gradle verion in tests from 6.1 to 6.1.1
3452d32 
reason: gradle/gradle#11966
ausatiy added a commit to JetBrains/kotlin that referenced this issue Mar 15, 2021
@ausatiy
Update Gradle verion in tests from 6.1 to 6.1.1
9c00000 
Gradle 6.1 is not suitable for testing because of memory leak on
artefact validation (gradle/gradle#11966)
ausatiy added a commit to JetBrains/kotlin that referenced this issue Mar 15, 2021
@ausatiy
Update Gradle verion in tests from 6.1 to 6.1.1
71e41b7 
Gradle 6.1 is not suitable for testing because of memory leak on
artefact validation (gradle/gradle#11966)

(cherry picked from commit 9c00000)
ausatiy added a commit to JetBrains/kotlin that referenced this issue Mar 15, 2021
@ausatiy
Update Gradle verion in tests from 6.1 to 6.1.1
e4704db 
Gradle 6.1 is not suitable for testing because of memory leak on
artefact validation (gradle/gradle#11966)

(cherry picked from commit 9c00000)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melix melix

Labels
a:bug in:dependency-management DO NOT USE
Projects
None yet
Milestone
6.1.1
Development

Successfully merging a pull request may close this issue.

Do not read the full file in-memory when computing checksums gradle/gradle
2 participants
@melix @big-guy