Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project name disambiguation causes project / external dependency conflicts to be missed. #12315

Closed
ljacomet opened this issue Feb 21, 2020 · 1 comment
Assignees
Milestone

Comments

@ljacomet
Copy link
Member

The fix done in #11859 for #847 has an unfortunate side effect for project / binary dependency replacement.

If a project foo:api, with another project named *:api in the same multi project, was replacing a binary dependency org.test:api before the fix, it will no longer replace it after the fix as its name changed to foo-api, changing the coordinates, and causing the conflict to be missed.

@ljacomet ljacomet added this to the 6.2.1 milestone Feb 21, 2020
@ljacomet ljacomet self-assigned this Feb 21, 2020
@ljacomet
Copy link
Member Author

This has been resolved by reverting in 6.2.1 the fix for #847 done in 6.2, which had unforeseen consequences.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant