Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multi-project build use the properties of the rootProject for all included builds (changed in 6.2) #12381

Closed
ogermann opened this issue Feb 28, 2020 · 0 comments · Fixed by #12401
Closed

multi-project build use the properties of the rootProject for all included builds (changed in 6.2) #12381

ogermann opened this issue Feb 28, 2020 · 0 comments · Fixed by #12401
Assignees
@bamboo
Labels
a:regression This used to work
Milestone
6.2.2

Comments

@ogermann
Copy link

Expected Behavior

In a multiproject-build each project use their own gradle.properties while accessed from a settings.gradle file.

Current Behavior

Each project in a multiproject-build use the gradle.properties of the rootProject if accessed from a settings.gradle file and ignore the properties of the gradle.properties file declared in the directory of the included project.

Context

It had the expected behaviour with 6.1.1 and changed with 6.2.
We have many generic tasks used by many projects and their behaviour can be changed by setting properties. For example we conditionally include some default projects (composite build) if the project is of a specific type (this type is set via property in the gradle.properties). Sure we can move these props into the project-specific settings.gradle file, but this seems kind of inefficient.

Steps to Reproduce

Github Example

Your Environment

6.2 Build scan
6.1.1 Build Scan
@bamboo bamboo self-assigned this Mar 2, 2020
@bamboo bamboo added this to the 6.3 RC1 milestone Mar 2, 2020
bamboo added a commit that referenced this issue Mar 2, 2020
@bamboo
Reinstate PropertiesLoadingSettingsProcessor
a7209e1 
To ensure `GradleProperties` is loaded before processing the settings scripts of
any included builds.

The integration with instant execution is mediated by the newly introduced
`GradlePropertiesController` service which guarantees `GradleProperties` is
loaded only once during a build and from the correct location.

Fixes #12381
@bamboo bamboo mentioned this issue Mar 2, 2020
Merged
@big-guy big-guy modified the milestones: 6.3 RC1, 6.2.2 Mar 2, 2020
bamboo added a commit that referenced this issue Mar 4, 2020
@bamboo
Reinstate PropertiesLoadingSettingsProcessor
6abcc3f 
To ensure `GradleProperties` is loaded before processing the settings scripts of
any included builds.

The integration with instant execution is mediated by the newly introduced
`GradlePropertiesController` service which guarantees `GradleProperties` is
loaded only once during a build and from the correct location.

Fixes #12381
@big-guy big-guy closed this as completed Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bamboo bamboo

Labels
a:regression This used to work
Projects
None yet
Milestone
6.2.2
Development

Successfully merging a pull request may close this issue.

Make Gradle properties available to settings scripts gradle/gradle
4 participants
@bamboo @jjohannes @big-guy @ogermann