New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix multiple annotation processing issues discovered by Micronaut #19067
Conversation
Since this was a regression in 7.3, consider making this a 7.3.1 candidate. |
@ljacomet FYI |
Thanks for the fix Stefan! We have plans for a 7.3.1, adding this. |
Could you move these changes to be based off the |
Fixes micronaut-projects/micronaut-core#6536 Signed-off-by: Stefan Oehme <st.oehme@gmail.com>
Otherwise generated files from old compilations would be forgotten. Signed-off-by: Stefan Oehme <st.oehme@gmail.com>
f46ab4e
to
b2ba8ea
Compare
Done |
@bot-gradle test this |
OK, I've already triggered ReadyForMerge build for you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, I just added some questions to the change.
...rg/gradle/api/tasks/compile/AggregatingIncrementalAnnotationProcessingIntegrationTest.groovy
Outdated
Show resolved
Hide resolved
.../org/gradle/api/tasks/compile/IsolatingIncrementalAnnotationProcessingIntegrationTest.groovy
Outdated
Show resolved
Hide resolved
...java/org/gradle/api/internal/tasks/compile/incremental/IncrementalResultStoringCompiler.java
Show resolved
Hide resolved
...a/src/main/java/org/gradle/api/internal/tasks/compile/incremental/deps/ClassSetAnalysis.java
Show resolved
Hide resolved
b6e8176
to
7a897d3
Compare
@bot-gradle test and merge |
OK, I've already triggered a build for you. |
Hey - I'm eagerly waiting to try this out and see if it fixes our Micronaut build issues too. Unfortunately, I haven't figured out how to install Gradle locally, so my next best option is to wait for this to merge and be available in one of the nightly releases. Once merged, will it be in the 7.4 nightly or 7.3 nightly? https://gradle.org/release-nightly/ And of course, if you can point me to where I can solve my local Gradle install issues, I could verify this fix for our issues prior to merge ;) |
@lightbody run |
@oehme Thanks. I was doing I think I'm using it now and, if so, it unfortunately doesn't solve my problem. We're seeing the same errors reported in that original Micronaut ticket. I'm going to try to triple check that I am indeed using the right build (I'm running |
@lightbody when you have a reproducer, just create a new issue and ping me on it and I'll look into it. |
Fixes micronaut-projects/micronaut-core#6536
Contributor Checklist
<subproject>/src/integTest
) to verify changes from a user perspective<subproject>/src/test
) to verify logic./gradlew sanityCheck
./gradlew <changed-subproject>:quickTest
Gradle Core Team Checklist