Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

toolchainManagement.jvm.javaRepositories should not expose the full surface of NamedDomainObjectList #23016

Closed
jbartok opened this issue Dec 7, 2022 · 2 comments · Fixed by #23112
Closed

toolchainManagement.jvm.javaRepositories should not expose the full surface of NamedDomainObjectList #23016

jbartok opened this issue Dec 7, 2022 · 2 comments · Fixed by #23112
Assignees
@jbartok
Labels
a:bug in:toolchains Java Toolchains
Milestone
7.6.1

Comments

@jbartok
Copy link
Member

jbartok commented Dec 7, 2022

We should delegate to NamedDomainObjectList, not extend it.
@jbartok jbartok added this to the 7.6.1 milestone Dec 7, 2022
@jbartok jbartok self-assigned this Dec 7, 2022
@jbartok jbartok mentioned this issue Dec 7, 2022
Closed
@jbartok
Copy link
Member Author

jbartok commented Dec 7, 2022

Also keep observability, even if not live.

@jbartok jbartok mentioned this issue Dec 8, 2022
Merged
@jbartok
Copy link
Member Author

jbartok commented Dec 10, 2022

Needs further improvements.

@jbartok jbartok reopened this Dec 10, 2022
@jbartok jbartok mentioned this issue Dec 12, 2022
Merged
@ov7a ov7a added in:toolchains Java Toolchains and removed to-triage labels May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbartok jbartok

Labels
a:bug in:toolchains Java Toolchains
Projects
None yet
Milestone
7.6.1
Development

Successfully merging a pull request may close this issue.

Do not expose named domain object list, take 2 gradle/gradle
2 participants
@ov7a @jbartok