Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport JUnit5 dynamic test logging bug fix #23458

Closed
robmoore-i opened this issue Jan 10, 2023 · 6 comments
Closed

Backport JUnit5 dynamic test logging bug fix #23458

robmoore-i opened this issue Jan 10, 2023 · 6 comments
Assignees
@ljacomet
Labels
a:chore Minor issue without significant impact in:testing-junit5 junit platform vintage jupiter
Milestone
7.6.2

Comments

@robmoore-i
Copy link
Member

robmoore-i commented Jan 10, 2023 •
edited

@robmoore-i robmoore-i added a:chore Minor issue without significant impact to-triage labels Jan 10, 2023
@robmoore-i robmoore-i added this to the 7.x backport milestone Jan 10, 2023
@ljacomet ljacomet added in:testing-junit5 junit platform vintage jupiter and removed to-triage labels Jan 10, 2023
@robd
Copy link

robd commented Mar 7, 2023

Hi - is there a possibility that this will be backported to 7.x?

@robmoore-i
Copy link
Member Author

It should be - that's what this issue is for. @ljacomet can you give an update here? Also why wasn't this included in the most recent 7.x patch?

@robd
Copy link

robd commented Mar 22, 2023

Hi - is there anything I can do to help get this backported to next 7.x release?

@ljacomet
Copy link
Member

Items in the 7.x backport milestone were explicitly not in scope for Gradle 7.6.1.

The Gradle team still need to agree on plans for a Gradle 7.6.2 or 7.7 depending on the scope of the backports. This will not happen until Gradle 8.1 is released though.

@robd
Copy link

robd commented Mar 23, 2023

Ok thanks - let me know if there's anything I can do to help

@ljacomet ljacomet self-assigned this May 22, 2023
ljacomet pushed a commit that referenced this issue May 22, 2023
@robmoore-i @ljacomet
Fix JUnit5 dynamic test logging
5f13443 
Previously, these tests were displayed using their method name,
rather than their given, intended display name.

This looked like this:
... > MyTest.dynamicTestStream()[1]

With this change, they should look more like this:
... > MyTest.intended display name

Fixes #23458
@ljacomet ljacomet mentioned this issue May 22, 2023
Merged
bot-gradle added a commit that referenced this issue May 25, 2023
@bot-gradle @ghale
Merge pull request #25137 Testing fixes 7.6.2
9ba673d 
Fixes:
* #23458
* #24901

Co-authored-by: Gary Hale <gary@gradle.com>
@ljacomet
Copy link
Member

Done in #25137

@ZorinFoss ZorinFoss mentioned this issue Nov 14, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ljacomet ljacomet

Labels
a:chore Minor issue without significant impact in:testing-junit5 junit platform vintage jupiter
Projects
None yet
Milestone
7.6.2
Development

No branches or pull requests
3 participants
@robd @ljacomet @robmoore-i