Dependency graph resolution: Equivalent excludes can cause un-necessary graph mutations #23521
Comments
ljacomet
added a commit
that referenced
this issue
Jan 27, 2023
Failing to do that was breaking the contract of DependencyState deduplication. Issue #23521
This was referenced Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Following the fix for #17964, another subtle bug has been introduced when graphs have large excludes and a heavy use of dependency substitutions.
In some cases, changes in the
ExcludeSpecwill incorrectly be interpreted as impacting the graph, while the dependency nodes remain strictly the same.The root cause is that the
DependencyStatetype is expected to be deduplicated and itsequalsis limited to object identity.However in
NodeState.maybeSubstitute, the substitutedDependencyStateis not cached. A cache needs to be added there, building on the cache forSubstitutionResult, so that for a sourceDependencyState, a given result, the same modifiedDependencyStateis returned.The text was updated successfully, but these errors were encountered: