Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Toolchain related deprecation nagging in 7.6 #23555

Closed
jbartok opened this issue Jan 17, 2023 · 1 comment
Closed

Improve Toolchain related deprecation nagging in 7.6 #23555

jbartok opened this issue Jan 17, 2023 · 1 comment
Assignees
Labels
a:bug in:toolchains Java Toolchains
Milestone

Comments

@jbartok
Copy link
Member

jbartok commented Jan 17, 2023

Continues the fixes started in

Specifically: in Gradle 7.6 we have deprecation nagging in case there are no toolchain repositories configured, but it gets activated only when auto-provisioning actually happens. This is not enough, not even for builds that rely on the feature, because even those only download a toolchain once and then just use it in subsequent runs. We should always nag, if toolchains are being used. This needs to be backported to 7.6.1.

@jbartok jbartok self-assigned this Jan 17, 2023
@jbartok jbartok added in:toolchains Java Toolchains and removed to-triage labels Jan 17, 2023
@jbartok jbartok added this to the 7.6.1 milestone Jan 17, 2023
bot-gradle added a commit that referenced this issue Jan 18, 2023
…ng in 7.6

Fixes
* #23555

Co-authored-by: József Bartók <jbartok@gradle.com>
@jbartok
Copy link
Member Author

jbartok commented Jan 19, 2023

Has been done for 7.6.1, being merged into 8.0 too.

@jbartok jbartok closed this as completed Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:bug in:toolchains Java Toolchains
Projects
None yet
Development

No branches or pull requests

1 participant