Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--no-rebuild suddenly gone without new deprecation cycle and without the reason for its undeprecation being void #23888

Closed
Vampire opened this issue Feb 13, 2023 · 3 comments · Fixed by #23921
Closed

--no-rebuild suddenly gone without new deprecation cycle and without the reason for its undeprecation being void #23888

Vampire opened this issue Feb 13, 2023 · 3 comments · Fixed by #23921
Assignees
@eskatos
Labels
a:regression This used to work affects-version:8.0 in:invoking-gradle Running Executing
Milestone
8.0.1

Comments

@Vampire
Copy link
Contributor

Vampire commented Feb 13, 2023

A little timeline of what happened:

Oct 4, 2017
#3077
"Deprecate --no-rebuild"
issue created

Oct 18, 2017
#3121
"Deprecate --no-rebuild"
flag deprecated

Aug 9, 2018
#6305
"Remove --no-rebuild"
issue created

Sep 27, 2018
#6917
"Remove -a/--no-rebuild command line option"
pull request created, but not merged
it was decided to not do this step until #6045 is resolved which it still is not
instead it was decided to undeprecate the flag
unfortunately #6305 was not closed along

Oct 1, 2018
#6968
"Undeprecate --no-rebuild and document its usefulness when working on buildSrc"
issue created

Oct 11, 2018
#7319
"Undeprecate --no-rebuild"
flag was undeprecated and is since then

Dec 6, 2022
#22992
"Remove --no-rebuild command line option"
now suddenly the flag got removed without prior warning, without deprecation, without the #6045 being resolved and without the flag being less useful for those who know to use it wisely

Please reintroduce the flag.
@Vampire Vampire added a:regression This used to work to-triage labels Feb 13, 2023
@eskatos eskatos added this to the 8.1 RC1 milestone Feb 15, 2023
@eskatos
Copy link
Member

eskatos commented Feb 15, 2023

Thank you for your interest in Gradle!

Good catch. We will fix that in the next 8.x release. Right now this is 8.1 but it might change if we decide to do an 8.0.1.

@eskatos eskatos modified the milestones: 8.1 RC1, 8.0.1 (unconfirmed) Feb 15, 2023
@eskatos eskatos mentioned this issue Feb 16, 2023
Merged
@eskatos eskatos self-assigned this Feb 16, 2023
bot-gradle added a commit that referenced this issue Feb 16, 2023
@bot-gradle @eskatos
Merge pull request #23921 Restore --no-rebuild command line option
fa74f94 
* Reverts #22992
* Fixes #23888

Co-authored-by: Paul Merlin <paul@gradle.com>
@eskatos eskatos linked a pull request Feb 16, 2023 that will close this issue
Restore --no-rebuild command line option #23921
Merged
@ljacomet
Copy link
Member

Will be fixed in 8.0.1

@Vampire
Copy link
Contributor Author

Vampire commented Feb 17, 2023

Nice, many thanks for the quick restoration. :-)

This was referenced Feb 20, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Feb 27, 2023
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eskatos eskatos

Labels
a:regression This used to work affects-version:8.0 in:invoking-gradle Running Executing
Projects
None yet
Milestone
8.0.1
Development

Successfully merging a pull request may close this issue.

Restore --no-rebuild command line option gradle/gradle
3 participants
@eskatos @ljacomet @Vampire