Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude rule merging: missing optimization [Backport 7.x] #23951

Closed
ljacomet opened this issue Feb 17, 2023 · 1 comment
Closed

Exclude rule merging: missing optimization [Backport 7.x] #23951

ljacomet opened this issue Feb 17, 2023 · 1 comment
Assignees
@ljacomet
Labels
a:chore Minor issue without significant impact in:dependency-resolution engine metadata
Milestone
7.6.2

Comments

@ljacomet
Copy link
Member

@ljacomet ljacomet added a:chore Minor issue without significant impact in:dependency-resolution engine metadata labels Feb 17, 2023
@ljacomet ljacomet added this to the 7.x backport milestone Feb 17, 2023
@ljacomet ljacomet self-assigned this Feb 17, 2023
@ljacomet ljacomet mentioned this issue May 15, 2023
Merged
ljacomet added a commit that referenced this issue May 16, 2023
@ljacomet
Add missing optimization to exclude merging
c862215 
The missing optimization was for a module Id and a set of module names.
In that case, we keep the module id only if its name is in the set.

Fixes #23951
bot-gradle added a commit that referenced this issue May 22, 2023
@bot-gradle @ljacomet
Merge pull request #25060 Dependency resolution fixes
3a6ce9c 
* #23681
* #23951
* #24443

Co-authored-by: Louis Jacomet <louis@gradle.com>
@ljacomet
Copy link
Member Author

Done through #25060

@ZorinFoss ZorinFoss mentioned this issue Nov 14, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ljacomet ljacomet

Labels
a:chore Minor issue without significant impact in:dependency-resolution engine metadata
Projects
None yet
Milestone
7.6.2
Development

No branches or pull requests
1 participant
@ljacomet