New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The Build Hangs in Gradle 4.0.0+ #2415
Comments
@rwinch Can you share your gradle configuration? For example, are you using |
@eriwen Thanks for the fast response. I'm not sure I follow. I provided the command I am running with (perhaps it was just missed). You can find it again below
My gradle build files are in GitHub. Is there something else you were looking for? |
@rwinch BTW, just for future reference, you can have configuration in
That's the kind of thing we'd want to know. Note that in this case it's not important since we think we know what the issue is |
@eriwen Thanks for letting me know. Just so all information is present... I do not have a I also do not have an |
Got it. Sorry, you're right about the paths. |
No worries...just making sure I'm not missing something :-D Thanks again for the awesome response times! |
@rwinch I wasn't able to reproduce the problem with your test project, however I did manage to write an integration test which exhibits the same behavior. If possible, would you mind testing if your problem is solved using this branch ? You should be able to create a distribution running:
|
@melix Thanks for the response! Sadly I'm currently unable to reproduce the issue using Gradle 4.0.1 either. As I mentioned in the description, this was running from June 16th till late last week without issues. So I suspect something must have changed around that time frame. My guess is that the bug combined with perhaps a slow Given I cannot currently reproduce the issue, I'm (unfortunately) not in a better position to verify this has been fixed. Based on your description of what you fixed, it does appear that you figure out the issue. I did also run your branch against my build a number of times and it appears to be working as well. Thanks again for the fast fix and I hope this helps. |
No worries, thanks Rob. I found that timing has to be very specific to trigger the problem (learnt it the hard way trying to write a test to reproduce it ;)). So I'm not surprised that the issue has "gone". However the PR does fix a problem so I'll just go ahead and merge. Thanks for your feedback! |
@melix Thanks! For what it's worth....I'll leave up to the Gradle team to decide to close or not, but from my perspective this ticket can be closed. If I encounter an issue again I can always create a new ticket. Thanks again for the awesome turnaround! |
A fix has been committed by @melix. This will definitely be in the next minor release of Gradle, if not in a patch release. |
Expected Behavior
The build should consistently complete.
Current Behavior
Frequently, but not consistently, the Spring Session build will hang.
It is worth mentioning that we had been using Gradle 4.0 since June 16th and did not start experiencing issues until two days ago. Now the issues are rather consistent in both our Jenkins and Travis builds. I have reverted to Gradle 3.5 and that appears to have fixed the issue.
NOTE: You can find a YourKit SNAPSHOT of the build hanging in Gradle 4.0.1 at https://github.com/rwinch/gradle-gh-2415
Here is a Thread dump of it hanging with Gradle 4.0.
Here is a dump from 4.0.1
Context
Steps to Reproduce (for bugs)
Your Environment
You can reproduce the issue by running the following command
on
5845a9c46a98d77cb72354db9788278f1d4b4dbd
from master in https://github.com/spring-projects/spring-sessionYou can also update to Gradle 4.0.1 from the version above and the build will still hang.
The text was updated successfully, but these errors were encountered: