Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maven artifact referenced only in dependency constraints raises IllegalStateException: Corrupt serialized resolution result [backport] #24443

Closed
ljacomet opened this issue Mar 22, 2023 · 1 comment
Closed

Maven artifact referenced only in dependency constraints raises IllegalStateException: Corrupt serialized resolution result [backport] #24443

ljacomet opened this issue Mar 22, 2023 · 1 comment
Assignees
@ljacomet
Labels
a:bug has:reproducer Indicates the issue has a confirmed reproducer in:dependency-resolution engine metadata in:gradle-module-metadata
Milestone
7.6.2

Comments

@ljacomet
Copy link
Member

See
@ljacomet ljacomet added a:bug in:gradle-module-metadata in:dependency-resolution engine metadata has:reproducer Indicates the issue has a confirmed reproducer labels Mar 22, 2023
@ljacomet ljacomet added this to the 7.x backport milestone Mar 22, 2023
@ljacomet ljacomet self-assigned this May 16, 2023
ljacomet added a commit that referenced this issue May 16, 2023
@ljacomet
Drop duplicates from GMM
76c8edf 
When parsing Gradle Module Metadata, Gradle drops duplicate dependencies
 and constraints declarations.
 This is now consistent with the way Maven metadata is handled.

 Note that this only applies to strict duplicates, declaring a
 dependency on different variants or capabilites remain supported.

 Fixes #24443
ljacomet added a commit that referenced this issue May 16, 2023
@ljacomet
Move deduplication logic
1cd2a9b 
Deduplication is now the focus of the parser. The metadata classes no
longer checks for duplicates.

Includes a fix in the equals / hashcode of some internal types that were
 not evolved since new fields were added.

 Issue #24443
ljacomet added a commit that referenced this issue May 16, 2023
@ljacomet
Document deduplication requirement
0f61617 
Also add safety test for equals / hashcode implementation.

Issue #24443
ljacomet added a commit that referenced this issue May 16, 2023
@ljacomet
Adds more tests for contract enforcement
7bdc759 
* Make sure changes in class hierarchy are accounted for
* Fix copy / paste error in javadoc

Issue #24443
@ljacomet ljacomet mentioned this issue May 16, 2023
Merged
ljacomet added a commit that referenced this issue May 17, 2023
@ljacomet
Account for Gradle 7.6.2 metadata cache layout
00bb956 
Because we lacked a gap between 7.5 and 8.0 and 7.6.2 requires a cache
layout bump, we are forced to add this version with an exception.

Issue #24443
bot-gradle added a commit that referenced this issue May 22, 2023
@bot-gradle @ljacomet
Merge pull request #25060 Dependency resolution fixes
3a6ce9c 
* #23681
* #23951
* #24443

Co-authored-by: Louis Jacomet <louis@gradle.com>
@ljacomet
Copy link
Member Author

Done through #25060

ljacomet added a commit that referenced this issue May 26, 2023
@ljacomet
Account for Gradle 7.6.2 metadata cache layout
c8a4f08 
Because we lacked a gap between 7.5 and 8.0 and 7.6.2 requires a cache
layout bump, we are forced to add this version with an exception.

Issue #24443
@ZorinFoss ZorinFoss mentioned this issue Nov 14, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ljacomet ljacomet

Labels
a:bug has:reproducer Indicates the issue has a confirmed reproducer in:dependency-resolution engine metadata in:gradle-module-metadata
Projects
None yet
Milestone
7.6.2
Development

No branches or pull requests
1 participant
@ljacomet