Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport cgroups fix to 7.6.x #25802

Closed
ghale opened this issue Jul 18, 2023 · 2 comments
Closed

Backport cgroups fix to 7.6.x #25802

ghale opened this issue Jul 18, 2023 · 2 comments
Assignees
@ljacomet
Labels
a:chore Minor issue without significant impact in:workers
Milestone
7.6.3

Comments

@ghale
Copy link
Member

ghale commented Jul 18, 2023

In 8.1, we fixed #17610 with #23944. If we do a 7.6.3, we should backport this fix.
@ghale ghale added this to the 7.x backport milestone Jul 18, 2023
@big-guy big-guy added the a:chore Minor issue without significant impact label Jul 18, 2023
@OussamaHaff
Copy link

Hey!
Thank you @ghale and @Thrillpool for the fix 🙏

We are suffering from the same symptoms mentioned in #17610 on a large Android codebase with Docker setup for CI.
We have been fine-tuning per project/module max heap to avoid JVM crashes on CI, but with a growing codebase it is no more sufficient to cover the symptoms.

Similar case to @CRogers's comment, we will be thankful if you can backport the fix to Gradle 7.6.x since the upgrade to Gradle 8 will take us couple of months.

@ljacomet ljacomet mentioned this issue Sep 29, 2023
Merged
@ljacomet ljacomet modified the milestones: 7.x backport, 7.6.3 Sep 29, 2023
@ljacomet ljacomet self-assigned this Sep 29, 2023
bot-gradle added a commit that referenced this issue Sep 29, 2023
@bot-gradle @ljacomet
Merge pull request #26584 Backport of fixes to 7.6.3
3b40619 
Fixes
* #25802
* #25781

Co-authored-by: Louis Jacomet <louis@gradle.com>
@ljacomet
Copy link
Member

ljacomet commented Oct 4, 2023

Done through:

@ljacomet ljacomet closed this as completed Oct 4, 2023
@ZorinFoss ZorinFoss mentioned this issue Nov 14, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ljacomet ljacomet

Labels
a:chore Minor issue without significant impact in:workers
Projects
None yet
Milestone
7.6.3
Development

No branches or pull requests
4 participants
@ljacomet @ghale @big-guy @OussamaHaff