Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle signature verification fails when gradle module metadata uses a relative path redirect #28862

Open
liutikas opened this issue Apr 18, 2024 · 1 comment
Labels
a:bug in:dependency-verification trustkey truststore checksum signature 👋 team-triage Issues that need to be triaged by a specific team

Comments

@liutikas
Copy link
Contributor

Current Behavior

Guava started publishing artifacts with gradle module metadata. Their metadata uses

      "files": [
        {
          "name": "guava-32.1.3-jre.jar",
          "url": "../32.1.3-jre/guava-32.1.3-jre.jar"
        }
      ],

in https://repo1.maven.org/maven2/com/google/guava/guava/32.1.3-android/guava-32.1.3-android.module for making sure that consumers get the correct variant.

Gradle signature verification fails in such a "swap". It does not even seem to find .asc file as it only does checksum verification.

Dependency verification failed for configuration ':app:debugRuntimeClasspath'
One artifact failed verification: guava-32.1.3-android.jar (com.google.guava:guava:32.1.3-jre) from repository MavenRepo

Expected Behavior

Signature verification passes as ../32.1.3-jre/guava-32.1.3-jre.jar.asc exists and is valid

Context (optional)

Additional details in the guava tracker google/guava#7154

Steps to Reproduce

  1. Check out https://github.com/liutikas/guava-signature-repro
  2. ./gradlew assembleDebug

Gradle version

8.7

Build scan URL (optional)

https://scans.gradle.com/s/bcgzjbu55sm7y

Your Environment (optional)

No response

@ov7a
Copy link
Member

ov7a commented Apr 18, 2024

The issue is in the backlog of the relevant team and is prioritized by them.

@ov7a ov7a added in:dependency-verification trustkey truststore checksum signature and removed to-triage labels Apr 18, 2024
@big-guy big-guy added the 👋 team-triage Issues that need to be triaged by a specific team label Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:bug in:dependency-verification trustkey truststore checksum signature 👋 team-triage Issues that need to be triaged by a specific team
Projects
None yet
Development

No branches or pull requests

3 participants