Importing generated eclipse projects results in build path errors

[epeee]

Expected Behavior

Running ./gradlew eclipse and importing the generated projects should not end up in build path errors.

Current Behavior

Running ./gradlew eclipse and importing the generated projects ends up in:
"Cannot nest 'projA/src/main/java' inside 'projA'. To enable the nesting exclude 'src/' from 'projA''" Build Path Problem.

Context

It looks like this one was introduced in Gradle 4.5. Using Gradle 4.4.1 the generated project can be imported to Eclipse without any errors.
This one is a minor one which can be fixed easily in the build.gradle file, but it might break some builds which are out there.

Steps to Reproduce

This can be reproduced by having a settings.gradle like

include 'projA'
include 'projB'

and a build.gradle like

subprojects {
    apply plugin: 'java'
    apply plugin: 'eclipse'

    dependencies {
        testCompile project(':projA')
    }
}

In order to use Gradle 4.5 we are adding the testCompile project(':projA') dependency only if the subproject is not 'projA'.

self-contained example: https://github.com/epeee/gradle-4172.

[bmuschko]

@donat Could you please look into this?

[donat]

This is probably related to the recent changes in the dependency resolution engine.

[jjohannes]

This is caused by a change in #3625.

The changes in #3625 are quite involved. So I don't know exactly what caused this. @oehme maybe you can have a look at his?

In the example, the new behavior adds <classpathentry kind="src" path="/projA"/> to the .classpath of projA which depends on itself. This then leads to the error.

[oehme]

@donat Could you fix the EclipseDependencyCreator? I forgot the self-dependency check like in the IDEA plugin. This means we are missing test coverage. You might want to double-check other implementations of IdeDependencyVisitor.

[epeee]

@oehme thx for the hint! I can confirm that the generated project can be imported without errors again after applying your fix (building gradle locally using fixes from https://github.com/epeee/gradle/tree/gradle-4172).
I have not checked other implementations of IdeDependencyVisitor though.

[oehme]

@donat Since we're doing a patch release anyway, we should fix this there as well. The release is on Monday, so could you look into this today? If not I'll try to free up some time.