Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Gradle 6 warnings #114

Open
PaulFridrick opened this issue Nov 22, 2019 · 4 comments
Open

Fix Gradle 6 warnings #114

PaulFridrick opened this issue Nov 22, 2019 · 4 comments

Comments

@PaulFridrick
Copy link
Contributor

PaulFridrick commented Nov 22, 2019

I use Gradle 6 and the playframework plugin. All these warnings seem to come from the plugin:

  • The baseName property has been deprecated. This is scheduled to be removed in Gradle 7.0. Please use the distributionBaseName property instead.

  • The ProjectLayout.configurableFiles() method has been deprecated. This is scheduled to be removed in Gradle 7.0. Please use the ObjectFactory.fileCollection() method instead.

  • The destinationDir property has been deprecated. This is scheduled to be removed in Gradle 7.0. Please use the destinationDirectory property instead.

  • The baseName property has been deprecated. This is scheduled to be removed in Gradle 7.0. Please use the archiveBaseName property instead.

  • The runtimeClasspath configuration has been deprecated for dependency declaration. This will fail with an error in Gradle 7.0. Please use the implementation or compileOnly or runtimeOnly configuration instead.

@lacasseio
Copy link

Thanks for notifying us about those warning. Would you be willing to provide us some PRs to remove each warning? Ideally, it would be best to provide one PR per warning type simply because there may be a minimum supported Gradle version we want to support and the alternate API may not be available. This way we can more easily merge the PRs and provide releases without warning. Thanks a lot.

@PaulFridrick
Copy link
Contributor Author

PaulFridrick commented Dec 9, 2019

I have one more fix (see PR PaulFridrick#1) that depends on the gradle 6 migration (PR #120), but it breaks the compatibility with Gradle 5 (the tests in InDepthUserGuideSamplesIntegrationTest fail with the versions "5.1.1", "5.2.1", "5.5.1" and "5.6.4").

@aadrian
Copy link

aadrian commented Dec 9, 2019

@PaulFridrick +1 for moving to Gradle 6.x and drop Gradle 5.

@DPUkyle
Copy link

DPUkyle commented Jun 15, 2020

My organization sees the following issue when building with 5.6.4:

image

I would prefer wrapping JavaScriptMinify line 44 with a version compatibility check. In pseudocode:

if (project.gradleVersion <= '5.1') {
  compilerClasspath = getProject().files()
} else {
  compilerClasspath = getProject().getObjects().fileCollection()
}

This same change would probably be necessary to all classes affected by this commit: ef775a8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants