Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support configuring agent clusterRole permission in values.yaml #196

Open
raphaelfan opened this issue Apr 3, 2024 · 5 comments · May be fixed by #716
Open

Support configuring agent clusterRole permission in values.yaml #196

raphaelfan opened this issue Apr 3, 2024 · 5 comments · May be fixed by #716
Labels
enhancement New feature or request

Comments

@raphaelfan
Copy link

Request

In the agent helm chart, the clusterRole perm are configured in https://github.com/grafana/agent/blob/main/operations/helm/charts/grafana-agent/templates/rbac.yaml. Depending on the components used, the user may not need all the permissions. Please make the perm configurable from values.yaml.

Use case

Allow users to configure clusterRole permissions based on the flow mode Components used in the agent.
@raphaelfan raphaelfan added the enhancement New feature or request label Apr 3, 2024
@hainenber hainenber mentioned this issue Apr 6, 2024
Closed
2 tasks
@rfratto rfratto transferred this issue from grafana/agent Apr 11, 2024
@raphaelfan
Copy link
Author

Hi, @hainenber, will you recreate the pull request for this feature in the alloy project? Thanks.

@hainenber
Copy link
Contributor

Sure, I'll port it to Alloy repo. Missed this one out

@hainenber hainenber linked a pull request Apr 30, 2024 that will close this issue
Open
2 tasks
@raphaelfan
Copy link
Author

Thank you!

@raphaelfan
Copy link
Author

Hi @hainenber , it looks like all the checks in the PR passed, do you have a rough idea when this will be reviewed and merged? Thanks.

@hainenber
Copy link
Contributor

I'm not sure tbh. It's up to the maintainers for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@raphaelfan @hainenber