feat(otelcol): allow overriding debug metric level for all otelcol components
#825
+686
−105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/sources/shared/reference/components/otelcol-debug-metrics-block.md
Outdated
Show resolved
Hide resolved
docs/sources/shared/reference/components/otelcol-debug-metrics-block.md
Outdated
Show resolved
Hide resolved
clayton-cornell
added
the
type/docs
docs/sources/shared/reference/components/otelcol-debug-metrics-block.md
Outdated
Show resolved
Hide resolved
rfratto
added
the
backport-to-agent:no
ptodev
reviewed
May 15, 2024
docs/sources/shared/reference/components/otelcol-debug-metrics-block.md
Outdated
Show resolved
Hide resolved
… except `auth.* due to cyclic imports Signed-off-by: hainenber <dotronghai96@gmail.com>
Signed-off-by: hainenber <dotronghai96@gmail.com>
…auth` components Signed-off-by: hainenber <dotronghai96@gmail.com>
…level Signed-off-by: hainenber <dotronghai96@gmail.com>
…ert` Signed-off-by: hainenber <dotronghai96@gmail.com>
Signed-off-by: hainenber <dotronghai96@gmail.com>
Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
Co-authored-by: Paulin Todev <paulin.todev@gmail.com> Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
Signed-off-by: hainenber <dotronghai96@gmail.com>
…of arg table Signed-off-by: hainenber <dotronghai96@gmail.com>
… components Signed-off-by: hainenber <dotronghai96@gmail.com>
…ation Signed-off-by: hainenber <dotronghai96@gmail.com>
hainenber
force-pushed
the
allow-override-debug-metric-level-for-otelcol-components
branch
from
45e98d7
to
f81140c
Compare
ptodev
reviewed
May 20, 2024
|
|
||
| Hierarchy | Block | Description | Required | ||
| ----------|------------|--------------------------------------|--------- | ||
| debug_metrics | [debug_metrics][] | Configures the metrics that this component generates to monitor its state. | no |
There was a problem hiding this comment.
Suggested change
| debug_metrics | [debug_metrics][] | Configures the metrics that this component generates to monitor its state. | no | |
| debug_metrics | [debug_metrics][] | Configures the metrics that this component generates to monitor its state. | no |
Would you mind doing a search and replace for this please? It's ok to put one space in every table, even if it's not consistent with the other rows in the table.
Signed-off-by: hainenber <dotronghai96@gmail.com>
clayton-cornell
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
otelcol.*componentsDebugMetricsas imethod for allotelcol.*Argument interfacedebug_metricsblock for allotelcol.*componentsDebugMetricsArgfor missing OtelCol componentsWhich issue(s) this PR fixes
Closes #792
Notes to the Reviewer
PR Checklist