Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Support "True Color" escape sequences in loki logs #35588

Closed
nevans opened this issue Jun 11, 2021 · 3 comments
Closed

Feature Request: Support "True Color" escape sequences in loki logs #35588

nevans opened this issue Jun 11, 2021 · 3 comments
Labels
area/explore datasource/Loki help wanted prio/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough interest in it. type/feature-request

Comments

@nevans
Copy link

nevans commented Jun 11, 2021

24-bit "direct" RGB colors in logfiles

Sometimes logfiles use 24bit RGB color escape sequences to distinguish between e.g. different email addresses using a checksum or for other reasons. Supporting the entire RGB color space would be useful.

The escape sequences used by almost all terminals with 24-bit RGB support are:

ESC[ 38;2;⟨r⟩;⟨g⟩;⟨b⟩ m => Select RGB foreground color
ESC[ 48;2;⟨r⟩;⟨g⟩;⟨b⟩ m => Select RGB background color

Perhaps I should also open an issue on the ansicolors npm package? At a very quick glance, I wasn't certain if adding 24bit RGB color support there would be API compatible or would require an update to grafana.

@zuchka zuchka changed the title Support "True Color" escape sequences in loki logs Feature Request: Support "True Color" escape sequences in loki logs Jun 11, 2021
@davkal
Copy link
Contributor

davkal commented Jun 30, 2021

@nevans we could use some help on this, could you verify if ansicolor supports this?

@Elfo404 Elfo404 added help wanted prio/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough interest in it. labels Sep 2, 2021
@nevans
Copy link
Author

nevans commented Nov 18, 2021

Sorry I lost track of this. No, it doesn't look like it does. I posted an issue here: xpl/ansicolor#17

@joey-grafana
Copy link
Contributor

joey-grafana commented Feb 21, 2022

Closing this as it's an issue in an external repo - and have posted to that repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/explore datasource/Loki help wanted prio/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough interest in it. type/feature-request
Projects
None yet
Development

No branches or pull requests

5 participants