Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus: Support forthcoming UTF-8 metric and label names in Prometheus #74875

Open
ywwg opened this issue Sep 13, 2023 · 3 comments
Open
Labels
datasource/Prometheus needs research for internal issues needing more research prio/high Must be staffed and worked on either currently, or very soon, ideally in time for the next release. type/feature-request

Comments

@ywwg
Copy link
Contributor

ywwg commented Sep 13, 2023

Why is this needed:

Prometheus will be adding support for UTF-8 in metric and label names, and Grafana will need updates to properly support the new syntax, for instance when validating queries and also in the Builder. The Prometheus issue is here: prometheus/prometheus#13095

What would you like to be added:

Per the forthcoming design doc, Grafana will need to support the updated language syntax. This is not finalized yet.

Who is this feature for?

This will be for Prometheus users who have metric names that don't comply with the previous character requirements.

@ywwg ywwg changed the title Support forthcoming UTF8 support in Prometheus Support forthcoming UTF8 metric names and labels in Prometheus Sep 13, 2023
@ywwg ywwg changed the title Support forthcoming UTF8 metric names and labels in Prometheus Support forthcoming UTF8 metric and label names in Prometheus Sep 13, 2023
@gtk-grafana gtk-grafana changed the title Support forthcoming UTF8 metric and label names in Prometheus Prometheus: Support forthcoming UTF8 metric and label names in Prometheus Oct 4, 2023
@itsmylife itsmylife added the prio/high Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Oct 6, 2023
@itsmylife itsmylife added the needs research for internal issues needing more research label Oct 17, 2023
@ywwg
Copy link
Contributor Author

ywwg commented Oct 24, 2023

@ywwg ywwg changed the title Prometheus: Support forthcoming UTF8 metric and label names in Prometheus Prometheus: Support forthcoming UTF-8 metric and label names in Prometheus Feb 8, 2024
@yuri-rs
Copy link
Contributor

yuri-rs commented May 17, 2024

@ywwg I can try to help with the Grafana part of the project

@ywwg
Copy link
Contributor Author

ywwg commented May 20, 2024

Great, thank you. I believe most of the task for Grafana will be supporting the new syntax in the code and builder views. For the code view, it needs to correctly recognize the syntax as valid, and for the builder view, it will need to construct queries with the new syntax when necessary. I am not sure how the functionality should be enabled -- I believe the datasource plugin will have to know what version of backend it's talking to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datasource/Prometheus needs research for internal issues needing more research prio/high Must be staffed and worked on either currently, or very soon, ideally in time for the next release. type/feature-request
Projects
None yet
Development

No branches or pull requests

4 participants