Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Licensing for Grafana Chart #2882

Closed
geCarlo opened this issue Jan 4, 2024 · 7 comments · Fixed by #2909
Closed

Question: Licensing for Grafana Chart #2882

geCarlo opened this issue Jan 4, 2024 · 7 comments · Fixed by #2909

Comments

@geCarlo
Copy link

geCarlo commented Jan 4, 2024

What does this license refer to (within the grafana chart.yml)?

"artifacthub.io/license": AGPL-3.0-only

Does this license apply to the grafana helm chart from this project? It seems obvious to me that it does not, given the apache license from the top of the project; however, I am confused by this metadata for this chart.. perhaps it is meant to serve as the most limiting license within the sources, being https://github.com/grafana/grafana?

ref:

"artifacthub.io/license": AGPL-3.0-only

@morsik
Copy link

morsik commented Jan 10, 2024

Clear description here: https://artifacthub.io/docs/topics/annotations/helm/

Use this annotation to indicate the chart’s license. By default, Artifact Hub tries to read the chart’s license from the LICENSE file in the chart, but it’s possible to override or provide it with this annotation

@rouke-broersma
Copy link

@morsik the license in the repo is apache: https://github.com/grafana/helm-charts?tab=Apache-2.0-1-ov-file#readme
So @geCarlo's question is still valid. Which license applies in this case, the license in the repo or the license set in the annotation in the chart? And is that only true when using the chart through artifacthub, since the annotation is specific to artifacthub?

@morsik
Copy link

morsik commented Jan 15, 2024

@rouke-broersma oh, that's interesting...

My guess is probably what's in artifacthub.io/license applies.

Keep in mind that this repo is not official Grafana Helm Charts. They are unofficial community charts and they were copied from multiple different places, so I don't think they can change licence randomly to Apache 2.0. And yeah... this is quite confusing here... None of the maintainers in helm-charts/charts/grafana/Chart.yaml have @grafana.com e-mail so...

And I would say that annotation just gives information to ArtifactHub's internal data, but it should apply everywhere - it still has the same meaning - mention licence for that chart.

@rouke-broersma
Copy link

rouke-broersma commented Jan 15, 2024

@morsik I disagree for two reasons, 1 the license annotation was added by a random contributor and 2 the annotation is metadata specifically for artifacthub and is not part of the official helm chart spec. I would argue that the annotation is most likely wrong and the actual license in the repo covers this chart. If the chart folder had it's own license file I might have agreed with you.

That this repo is unofficial only adds to my belief that the repo license is correct, because that license has been here since the start. It would be the agpl license that would be changing the license randomly.

@morsik
Copy link

morsik commented Jan 15, 2024

Soo... maybe we should ask author of 1a782b0 then? ;) @arukiidou - what's up with this licence?

After further research, it looks to me like @arukiidou's mistake - since Grafana is itself AGPL but Heml Charts aren't.

@arukiidou
Copy link
Contributor

arukiidou commented Jan 15, 2024

@morsik
sorry, It seems to have been confused for a grafana server.

@geCarlo geCarlo closed this as completed Jan 15, 2024
arukiidou added a commit to arukiidou/grafana-helm-charts that referenced this issue Jan 16, 2024
Signed-off-by: junya koyama <arukiidou@yahoo.co.jp>
Xtigyro added a commit that referenced this issue Jan 22, 2024
[grafana] fix Chart.yaml - fix incorrect license #2882
@arukiidou
Copy link
Contributor

arukiidou commented Jan 22, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants