Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[loki-distributed] memberlist not enabled in indexGateway despite indexGateway.joinMemberlist defaults to "true" #3024

Open
Skaronator opened this issue Mar 14, 2024 · 0 comments

Comments

@Skaronator
Copy link

Skaronator commented Mar 14, 2024

I noticed missing configuration for the indexGateway.

The helm-chart enables, by default, indexGateway.joinMemberlist: true which means that the Deployment is configured in a way to work with the memberlist. But this is not reflected in the Loki configuration.

By default, memberlist is not enabled for the indexGateway since index_gateway.mode: simple.

# -- Whether the index gateway should join the memberlist hashring
joinMemberlist: true

https://grafana.com/docs/loki/latest/configure/#index_gateway

So I'd suggest that indexGateway.joinMemberlist should default to false since it looks like, that this is only important in a multi tenant usecase. (which is by default also disabled)

I'd also suggest that correctly configuring index_gateway.mode and index_gateway.ring once indexGateway.joinMemberlist: true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant