Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mixin: networking overview renders useless panels for the gateway #7911

Open
QuentinBisson opened this issue Apr 17, 2024 · 1 comment
Open

Comments

@QuentinBisson
Copy link
Contributor

QuentinBisson commented Apr 17, 2024

Describe the bug

The networking overview dashboards renders the number of inflight request for the mimir gateway

.addRowIf($._config.gateway_enabled, $.containerNetworkingRowByComponent('Gateway', 'gateway'))
but the gateway(when using the non enterprise gateway which is nginx) will never expose the metrics used in those panel:

  • Inflight requests (per pod) uses cortex_inflight_requests
  • TCP connections (per pod) uses cortex_tcp_connections and cortex_tcp_connections_limit

Should those panels be removed for the gateway in the case that it uses nginx?

On that note, the rollout dashboard should probably be removable from the mixins as it's main use case it for the enterprise gateway

To Reproduce

Steps to reproduce the behavior:

  1. Start Mimir (SHA or version)
  2. Perform Operations(Read/Write/Others)

Expected behavior

A clear and concise description of what you expected to happen.

Environment

  • Infrastructure: [e.g., Kubernetes, bare-metal, laptop]
  • Deployment tool: [e.g., helm, jsonnet]

Additional Context

@dimitarvdimitrov
Copy link
Contributor

dimitarvdimitrov commented Apr 22, 2024

yeah i think it makes sense to remove those panels by default in the rendered dashboards. They are removed via $._config.gateway_enabled. I believe this is the config that's used for the config default dashboards https://github.com/grafana/mimir/blob/9090af52a8e104c37bb4da975bbefbf5185458cc/operations/mimir-mixin/mixin-compiled.libsonnet setting gateway_enabled: false in that file should do the job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants