[ENHANCEMENT] Add mimir-http-prefix option to introduce a prefix for Mimir URL when use legacy routes.
#8069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…url when use legacy routes
lamida
reviewed
May 9, 2024
| var err error | ||
| if path, err = url.JoinPath(cfg.MimirHTTPPrefix, legacyAPIPath); err != nil { | ||
| return nil, err | ||
| } | ||
| } |
There was a problem hiding this comment.
Nit. Should we validate that the user mustn't set MimirHTTPPrefix if UseLegacyRoutes is false? MimirHTTPPrefix is a new config, I think it might be better to strictly only allow this config when UseLegacyRoutes is set, instead of just ignoring the config.
There was a problem hiding this comment.
This might be tricky to check here, since MimirHTTPPrefix has a default value /prometheus, in client we will not able to distinguish the not set and default value.
lamida
reviewed
May 9, 2024
lamida
approved these changes
May 9, 2024
Co-authored-by: Jon Kartago Lamida <jon.lamida@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ENHANCEMENT] Add
mimir-http-prefixoption to introduce a prefix for Mimir URL when use legacy routes.What this PR does
clean up some mimirtool bugs, adding mimir-http-prefix for mimir client when use legacy routes
Which issue(s) this PR fixes or relates to
Fixes #8018
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.