Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

godeltaprof: delta computation order #72

Closed
korniltsev opened this issue Nov 28, 2023 · 0 comments
Closed

godeltaprof: delta computation order #72

korniltsev opened this issue Nov 28, 2023 · 0 comments

Comments

@korniltsev
Copy link
Collaborator

Currently delta profilers append locations, then compute delta, then reject sample if everything is zero.
We may want to change the order to compute delta, reject sample and only then append if we really need a sample.
This may produce smaller pprofs (avoid some locations) and may be faster. Need benchmarks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant