Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vet profiles at write #3194

Open
kolesnikovae opened this issue Apr 11, 2024 · 0 comments
Open

Vet profiles at write #3194

kolesnikovae opened this issue Apr 11, 2024 · 0 comments
Assignees
Labels
backend Mostly go code

Comments

@kolesnikovae
Copy link
Collaborator

kolesnikovae commented Apr 11, 2024

It has been discovered that some of the persisted profiles may contain invalid samples (stack trace ID == 0). This indicates that the ingestion handling allows malformed profiles to be written to blocks. Additionally, the profile references a symdb partition that does not contain any information except strings related to sample types, which is unexpected.

To prevent the persistence of malformed profiles, several checks should be performed just before a profile is written to the parquet table. Discarded malformed profiles should be tracked via metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Mostly go code
Projects
None yet
Development

No branches or pull requests

1 participant