Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a stub mapping for truncated nodes #3196

Open
kolesnikovae opened this issue Apr 11, 2024 · 1 comment
Open

Create a stub mapping for truncated nodes #3196

kolesnikovae opened this issue Apr 11, 2024 · 1 comment
Assignees
Labels
backend Mostly go code

Comments

@kolesnikovae
Copy link
Collaborator

When a pprof profile is truncated, we replace the removed nodes with a shared "stub" location (named "other") that references the default mapping (ID == 1), which may lead to ambiguity. Instead, a shared "stub" mapping should be created (probably, even if the profile already has a "stub" mapping created at ingestion).

@simonswine
Copy link
Contributor

Yes I do agree, esp. once we want to attach more information (OTEL spec) to the mapping we should be careful what belongs together or not.

@kolesnikovae kolesnikovae added the backend Mostly go code label Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Mostly go code
Projects
None yet
Development

No branches or pull requests

2 participants