Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing common.proto and trace.proto #3666

Open
XiangFrank opened this issue May 10, 2024 · 1 comment
Open

Missing common.proto and trace.proto #3666

XiangFrank opened this issue May 10, 2024 · 1 comment

Comments

@XiangFrank
Copy link

Describe the bug
In the pkg/tempopb/tempo.proto file, it import common.proto and trace.proto, these two files are supposed to be under /pkg/tempopb/common/v1 and /pkg/tempopb/trace/v1, but they are missing.

I suppose they should be the same to the OpenTelemetry proto common.proto and trace.proto, but still wanna confirm it and possibly add them back to avoid confusion.

To Reproduce
Steps to reproduce the behavior:

  1. Start Tempo (SHA or version)
  2. Perform Operations (Read/Write/Others)

Expected behavior

Environment:

  • Infrastructure: [e.g., Kubernetes, bare-metal, laptop]
  • Deployment tool: [e.g., helm, jsonnet]

Additional Context

@joe-elliott
Copy link
Member

Yup. We have a somewhat convoluted process to generate proto in the repo. Run make gen-proto from the root to create those files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants