Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize page.on events #1227

Open
3 tasks
ankur22 opened this issue Feb 29, 2024 · 1 comment
Open
3 tasks

Generalize page.on events #1227

ankur22 opened this issue Feb 29, 2024 · 1 comment
Labels
feature A new feature next Might be eligible for the next planning (not guaranteed!) playwright Issue relating to Playwright compatibility user request Requested by the community

Comments

@ankur22
Copy link
Collaborator

ankur22 commented Feb 29, 2024

Feature Description

We currently have page.on('console') which enables users to action on all console logs that the website under test logs. We have many community requests to add more event handling for other events. These event handling will enable users to perform more dynamic actions in their test when certain events occur which can help them capture, diagnose, and assert when things are not going well or are going well.

Suggested Solution (optional)

In Playwright they have the following events on page.on:

  • close
  • console
  • crash
  • dialog
  • domcontentloaded
  • download
  • filechooser
  • frameattached
  • framedetached
  • framenavigated
  • load
  • pageerror
  • popup
  • request
  • requestfailed
  • requestfinished
  • response
  • websocket
  • worker

Already existing or connected issues / PRs (optional)

#1153

Tasks

@ankur22 ankur22 added feature A new feature playwright Issue relating to Playwright compatibility next Might be eligible for the next planning (not guaranteed!) user request Requested by the community labels Feb 29, 2024
@ankur22 ankur22 mentioned this issue May 2, 2024
17 tasks
@inancgumus inancgumus changed the title Implement page.on events Generalize page.on events May 6, 2024
@inancgumus
Copy link
Member

I've changed this issue's title to focus on the generalization of page.on as the total work is lengthy. Please revert if you think otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature next Might be eligible for the next planning (not guaranteed!) playwright Issue relating to Playwright compatibility user request Requested by the community
Projects
None yet
Development

No branches or pull requests

2 participants