refactor(grails-gorm-testing-support): Replace deprecated usages of NavigableMap
#369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puneetbehl
changed the title
NavigableMapNavigableMap
puneetbehl
changed the title
NavigableMapNavigableMap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces deprecated usages of
NavigableMapso that it can be eventually removed and/or replaced by some other classes.More specifically,
NavigableMap.NullSafeNavigatorcan't be removed fromgrails-coreat the moment, because there are some test suites that depend onDataTestSetupSpecInterceptor:grails-test-suite-persistencegrails-test-suite-ubergrails-test-suite-webSo first we need to release a new version of
grails-testing-supportthat does not try to access the config in a deprecated way. Then we can continue exploring the possibility of removingNavigableMap.NullSafeNavigator.