Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkout attribute validation #304

Conversation

jithendraprasad9999
Copy link
Contributor

Resolves #303
Type: bugfix

Issue

In shopping cart page when we working as guest even though checkout attribute pre-selected value is none, it is defaulting to the first value,Even though it is a mandatory field, it is allowing us to proceed without any selection.

Solution

1.Added additional API call on "Continue As Guest" button to validate the checkout attribute using existing API from checkout controller.
2.And unified checkout buttons code

Breaking changes

none

Testing

  1. Navigate to shopping cart without any user login .
  2. If we tap on "Checkout As Guest" button without selecting any checkout attribute which is mandatory . One should get a model state error

@Nikhil13x Nikhil13x deleted the chcekout-attribute-validation branch April 18, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant