Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When we apply discount coupon code at cart even though valid products are not present cart , but message shows coupon code applied #434

Open
jithendraprasad9999 opened this issue Nov 17, 2023 · 3 comments

Comments

@jithendraprasad9999
Copy link
Contributor

In cart we have discount box where we add coupon codes, if we apply some random coupon codes which are not expired , we will get a message saying coupon code applied, This message leads lot of confusion to customer

@KrzysztofPajak
Copy link
Member

Hi @jithendraprasad9999 Could you explain what does it means:
"if we apply some random coupon codes"
Is there possible to reproduce on the demo ?

@jithendraprasad9999
Copy link
Contributor Author

@KrzysztofPajak , Yes we can reproduce.

  • Create a new discount with discount applied to products and pick few products in applied product list.
  • Enable require coupon code bool and add coupon code say "testsale"
  • Leave the requirements section untouched.
  • Now you can choose any products which are not configured for the discount and add them to cart
  • We can apply "testsale" coupon code to the cart and then will get a alert saying coupon code applied but discount will not get deducted

This leading a confusion to us

@KrzysztofPajak
Copy link
Member

@jithendraprasad9999, we have decided to leave this feature open for customization by the customer. You can create a new validator for the DiscountCouponModel and implement your own validation logic based on the contents of the cart.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants