Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix synchronous session connection #15

Closed
pietermees opened this issue Apr 5, 2018 · 2 comments
Closed

Fix synchronous session connection #15

pietermees opened this issue Apr 5, 2018 · 2 comments

Comments

@pietermees
Copy link

Due to nodejs/node#19839, the http2Connect callback at

fetch-h2/lib/context.ts

Line 214 in 4321b06

http2Connect( origin, options, ( ) => resolve( session ) );
doesn't get called if the session synchronously connected.
@grantila
Copy link
Owner

grantila commented Apr 9, 2018

Good catch. I'll wait for an upstream fix as of now.

@pietermees
Copy link
Author

Fixed by nodejs/node#19842

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@grantila @pietermees