Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-memory cache and close context #105

Open
eaglemoor opened this issue Apr 11, 2023 · 0 comments
Open

Non-memory cache and close context #105

eaglemoor opened this issue Apr 11, 2023 · 0 comments

Comments

@eaglemoor
Copy link

eaglemoor commented Apr 11, 2023

I found 2 problems in data loader.

  1. We can't use non-memory cache, because cache save lambda function.
  2. If user close context, batchFunc return error, and this error will be used in cache for all batch keys.

I fix it with DataCache interface and detachContext. PR #104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant