Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid $ at begging in ```sh codeblocks, require codeblock have language #358

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

dimaMachina
Copy link
Collaborator

fixes #350

@dimaMachina dimaMachina requested a review from a team as a code owner April 26, 2023 17:43
cargo run -p graph-node --release -- \
--postgres-url postgresql://USERNAME[:PASSWORD]@localhost:5432/graph-node \
--ethereum-rpc NETWORK_NAME:[CAPABILITIES]:URL \
--ipfs 127.0.0.1:5001
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
--ipfs 127.0.0.1:5001
--ipfs 127.0.0.1:5001 \

i think?

@github-actions
Copy link

📦 Next.js Bundle Analysis for @graphprotocol/docs

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Ten Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/en/cookbook/arweave 8.5 KB 599.52 KB 171.29% (🟡 +0.01%)
/en/cookbook/base-testnet 6.04 KB 597.07 KB 170.59% (+/- <0.01%)
/en/cookbook/cosmos 8.4 KB 599.42 KB 171.26% (+/- <0.01%)
/en/cookbook/grafting 7.6 KB 598.62 KB 171.03% (+/- <0.01%)
/en/cookbook/near 9.5 KB 600.52 KB 171.58% (+/- <0.01%)
/en/cookbook/quick-start 7.9 KB 598.92 KB 171.12% (+/- <0.01%)
/en/cookbook/subgraph-debug-forking 6.95 KB 597.97 KB 170.85% (+/- <0.01%)
/en/deploying/hosted-service 5.94 KB 596.96 KB 170.56% (+/- <0.01%)
/en/developing/unit-testing-framework 16.8 KB 607.82 KB 173.66% (+/- <0.01%)
/en/network/indexing 20.68 KB 611.71 KB 174.77% (+/- <0.01%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

Comment on lines -19 to -20
"prettier": "prettier . --loglevel warn --write",
"prettier:check": "prettier . --loglevel warn --check",
Copy link
Contributor

@benface benface Apr 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I previously added --loglevel warn because it lists all the files otherwise, even the ones that are correctly formatted, and I felt like it was uselessly verbose. Do you like that behavior, or does adding --cache and --list-different change it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it doesn't list all files, it updates only last line with linted file
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, so I just realized that --loglevel warn was only necessary if --check wasn't present (my bad for missing that), and that --list-different basically does the same thing, but it's even better because it looks like something's happening by updating that last line like you said. Awesome, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

forbid starting $ char in ```sh code blocks
2 participants