Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] graphman accepts deployment or namespace misleading to errors #5270

Open
1 of 3 tasks
rotarur opened this issue Mar 8, 2024 · 0 comments
Open
1 of 3 tasks

[Bug] graphman accepts deployment or namespace misleading to errors #5270

rotarur opened this issue Mar 8, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@rotarur
Copy link

rotarur commented Mar 8, 2024

Bug report

In graphman help, like graphman drop --help it accepts the DEPLOYMENT as an identifier to which SG to remove. The Deployment is unique everywhere in our system and if I try to drop a SG by using the deployment it will get removed from everywhere as usual.

The problem is that the drop command also accepts the namespace, which is unique only to the respective shard where this SG is deployed.

The graphman shouldn't accept the namespace if the help is saying to use the deployment identifier, otherwise it leads to critical mistakes when we want to remove the SG only from a specific shard and not from everywhere.

Also if you might consider this also as a feature request, there should be a possibility to drop the SG only from a specific shard by using it's namespace (if it's a single SG in that table, otherwise throw a warning that's not possible to remove it because there are multiple deployments using the same table)

Relevant log output

No response

IPFS hash

No response

Subgraph name or link to explorer

No response

Some information to help us out

  • Tick this box if this bug is caused by a regression found in the latest release.
  • Tick this box if this bug is specific to the hosted service.
  • I have searched the issue tracker to make sure this issue is not a duplicate.

OS information

macOS

@rotarur rotarur added the bug Something isn't working label Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant