Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding second contract fails if contract is not verified. #1607

Open
gotnoshoeson opened this issue Mar 2, 2024 · 0 comments
Open

Adding second contract fails if contract is not verified. #1607

gotnoshoeson opened this issue Mar 2, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@gotnoshoeson
Copy link

Which packages are impacted by your issue?

@graphprotocol/graph-cli

Describe the issue

Came upon this bug at ETHDenver @kmjones1979

When running graph init I am able to add a smart contract that is not verified by providing a file path for the ABI. Then there is a prompt to add another contract. If the contract is not verified, the etherscan verify fails and the program exits but DOESN'T have an option to provide a file path for the ABI like the first contract did.

I also tried to "graph add <CONTRACT_ADDRESS>", but it also exited when it wasn't able to etherscan verify.

Reproduction

https://github.com/gotnoshoeson/FanSocietyv2

Steps to Reproduce the Bug or Issue

  1. Run 'graph init --studio <SUBGRAPH_SLUG>' and follow the prompts to add the first contract 2. There will be a prompt to add another contract, select 'Yes'. 3. Follow the prompt and provide a contract address that has NOT been verified on etherscan.

Expected behavior

As a user, I was expecting that once the second contract verification failed I would be able to provide a file path for the ABI. This is how the tool works for the first contract.

Screenshots or Videos

No response

Platform

  • OS: macOS
  • NodeJS: v20.8.0
  • @graphprotocol/graph-cli/0.68.4 darwin-x64 node-v20.8.0

Subgraph Manifest

No response

Subgraph GraphQL Schema

No response

Additional context

No response

@gotnoshoeson gotnoshoeson added the bug Something isn't working label Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant