Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graph protogen command #1617

Open
saihaj opened this issue Mar 25, 2024 · 5 comments
Open

graph protogen command #1617

saihaj opened this issue Mar 25, 2024 · 5 comments
Labels
area/cli enhancement New feature or request

Comments

@saihaj
Copy link
Member

saihaj commented Mar 25, 2024

We also want to add a feature that will generate the protobuf-as types... currently this is either done with https://github.com/gravitational/protobuf-as but its broken atm -- @mangas created a branch that works https://github.com/mangas/protobuf-as
Ideally we would have a command in the CLI that was written like this... graph protogen --out=src/pb/ ./proto/*.proto
From @kmjones1979 on Slack

@saihaj saihaj added enhancement New feature or request area/cli labels Mar 25, 2024
@joshuanazareth97
Copy link
Contributor

Hi @saihaj, with your approval will pick this up next. Can we discuss any potential reasons for choosing protobuf-as vs ts-proto with protoc?

@joshuanazareth97
Copy link
Contributor

Hey @saihaj, if you have a moment can we discuss me picking this task? Will work on it today / over the weekend and close by Monday if possible. Just wanted to know about protobuf-ts vs ts-proto for the solution.

@azf20
Copy link
Contributor

azf20 commented May 3, 2024

thanks so much @joshuanazareth97! @mangas maybe has some context on that?

@joshuanazareth97
Copy link
Contributor

@mangas any input on using one vs the other?

@maoueh
Copy link
Contributor

maoueh commented May 6, 2024

We explored this a bit recently, see streamingfast/substreams-sink-examples#4.

The substreams protogen command uses buf to facilitate generation. We also used a different code generator than what was used before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants