Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: indexer_allocations limited to first 1000 #128

Closed
hopeyen opened this issue Feb 29, 2024 · 1 comment · Fixed by #178
Closed

Bug: indexer_allocations limited to first 1000 #128

hopeyen opened this issue Feb 29, 2024 · 1 comment · Fixed by #178
Assignees
Labels
type:bug Something isn't working

Comments

@hopeyen
Copy link
Collaborator

hopeyen commented Feb 29, 2024

Describe the bug

https://github.com/graphprotocol/indexer-rs/blob/main/common/src/allocations/monitor.rs#L68
This query string limits indexer_allocation query to first 1000 active allocations with no pagination. Shown by an instance that there exists indexer with 1000+ active allocations, this function fails to grab all eligible allocations for monitoring.

Expected behavior
Add pagination to the query and ensure all active allocations for an indexer are monitored.

Additional context
Uncovered by the same issue on TS version of indexer-service

@hopeyen hopeyen added the type:bug Something isn't working label Feb 29, 2024
@aasseman
Copy link
Collaborator

Corresponding fix in the TS version: graphprotocol/indexer#862

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
Status: Closed
Development

Successfully merging a pull request may close this issue.

3 participants