Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] More flexible IndexerServiceMetrics #136

Open
hopeyen opened this issue Mar 15, 2024 · 0 comments
Open

[Feat] More flexible IndexerServiceMetrics #136

hopeyen opened this issue Mar 15, 2024 · 0 comments
Labels
p3 Low priority type:feature New or enhanced functionality

Comments

@hopeyen
Copy link
Collaborator

hopeyen commented Mar 15, 2024

Problem statement
There's only 3 fields in the metrics tracked. It would be good to have flexibility in this struct so we can add more metrics for individual data services instead of hosting a separate metrics service.

pub struct IndexerServiceMetrics {
    pub requests: IntCounterVec,
    pub successful_requests: IntCounterVec,
    pub failed_requests: IntCounterVec,
}

Expectation proposal

Generic type/field added to IndexerServiceMetrics and function to register more metrics.

Alternative considerations
We can have a separate metrics server on the data service level, but that structure seems a bit convoluted for the data providers.

@hopeyen hopeyen added p3 Low priority type:feature New or enhanced functionality labels Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3 Low priority type:feature New or enhanced functionality
Projects
None yet
Development

No branches or pull requests

1 participant