-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add check for receipt value #164
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 9036265408Details
💛 - Coveralls |
gusinacio
previously requested changes
May 10, 2024
aasseman
approved these changes
May 10, 2024
aasseman
approved these changes
May 13, 2024
aasseman
added a commit
that referenced
this pull request
May 13, 2024
Signed-off-by: Alexis Asseman <alexis@semiotic.ai>
aasseman
added a commit
that referenced
this pull request
May 13, 2024
* refactor(common): inline config defaults Signed-off-by: Alexis Asseman <alexis@semiotic.ai> * feat(common): add more default config values Signed-off-by: Alexis Asseman <alexis@semiotic.ai> * docs(service): add min/max config file examples + tests The tests ensure that the config files are up to date with the code. I also looks like freezing `serde_spanned` is not needed anymore + needed to remove it to be able to add `toml`. Signed-off-by: Alexis Asseman <alexis@semiotic.ai> * docs(service): add doc to `--config` option Points to the example config files on github. Signed-off-by: Alexis Asseman <alexis@semiotic.ai> * feat(service): add env expansion for toml config file Signed-off-by: Alexis Asseman <alexis@semiotic.ai> * docs(service): improve config toml docs Signed-off-by: Alexis Asseman <alexis@semiotic.ai> * feat(service): remove commented lines from TOML config So that we can give examples for the shell expansion functionality in comments in the example config files. Signed-off-by: Alexis Asseman <alexis@semiotic.ai> * docs: update README.md Signed-off-by: Alexis Asseman <alexis@semiotic.ai> * fix(common): config support for #164 Signed-off-by: Alexis Asseman <alexis@semiotic.ai> --------- Signed-off-by: Alexis Asseman <alexis@semiotic.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #145