Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for receipt value #164

Merged
merged 2 commits into from May 13, 2024
Merged

Add check for receipt value #164

merged 2 commits into from May 13, 2024

Conversation

carlosvdr
Copy link
Contributor

issue #145

@carlosvdr carlosvdr self-assigned this May 10, 2024
@carlosvdr carlosvdr linked an issue May 10, 2024 that may be closed by this pull request
Copy link

Pull Request Test Coverage Report for Build 9036265408

Details

  • 63 of 67 (94.03%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.3%) to 67.413%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/src/indexer_service/http/indexer_service.rs 0 2 0.0%
common/src/tap.rs 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
common/src/indexer_service/http/indexer_service.rs 1 0.0%
Totals Coverage Status
Change from base Build 8932557105: 0.3%
Covered Lines: 3401
Relevant Lines: 5045

💛 - Coveralls

common/src/tap/checks/receipt_max_val_check.rs Outdated Show resolved Hide resolved
common/src/tap/checks/receipt_max_val_check.rs Outdated Show resolved Hide resolved
@carlosvdr carlosvdr requested a review from gusinacio May 10, 2024 20:30
@aasseman aasseman dismissed gusinacio’s stale review May 13, 2024 19:15

Issues got addressed

@aasseman aasseman merged commit d1f0c33 into main May 13, 2024
8 checks passed
@aasseman aasseman deleted the receipt-value-check branch May 13, 2024 19:15
aasseman added a commit that referenced this pull request May 13, 2024
Signed-off-by: Alexis Asseman <alexis@semiotic.ai>
aasseman added a commit that referenced this pull request May 13, 2024
* refactor(common): inline config defaults

Signed-off-by: Alexis Asseman <alexis@semiotic.ai>

* feat(common): add more default config values

Signed-off-by: Alexis Asseman <alexis@semiotic.ai>

* docs(service): add min/max config file examples + tests

The tests ensure that the config files are up to date with the code.
I also looks like freezing `serde_spanned` is not needed anymore + needed to remove it to be able to add `toml`.

Signed-off-by: Alexis Asseman <alexis@semiotic.ai>

* docs(service): add doc to `--config` option

Points to the example config files on github.

Signed-off-by: Alexis Asseman <alexis@semiotic.ai>

* feat(service): add env expansion for toml config file

Signed-off-by: Alexis Asseman <alexis@semiotic.ai>

* docs(service): improve config toml docs

Signed-off-by: Alexis Asseman <alexis@semiotic.ai>

* feat(service): remove commented lines from TOML config

So that we can give examples for the shell expansion functionality in comments
in the example config files.

Signed-off-by: Alexis Asseman <alexis@semiotic.ai>

* docs: update README.md

Signed-off-by: Alexis Asseman <alexis@semiotic.ai>

* fix(common): config support for #164

Signed-off-by: Alexis Asseman <alexis@semiotic.ai>

---------

Signed-off-by: Alexis Asseman <alexis@semiotic.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add hardlimit for receipt fee value on indexer-service
3 participants