feat: add value check #153
Conversation
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
Pull Request Test Coverage Report for Build 8759461513Details
💛 - Coveralls |
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
| Ok(()) | ||
| } else { | ||
| return Err(anyhow!( | ||
| "Query receipt does not have the minimum value. Expected value: {}. Minimum value: {}.", |
There was a problem hiding this comment.
| "Query receipt does not have the minimum value. Expected value: {}. Minimum value: {}.", | |
| "Query receipt does not have the minimum value. Expected value: {}. Received value: {}.", |
| let request = | ||
| serde_json::from_slice(&body).map_err(|e| IndexerServiceError::InvalidRequest(e.into()))?; | ||
|
|
||
| let mut attestation_signer: Option<AttestationSigner> = None; | ||
|
|
||
| if let Some(receipt) = receipt.into_signed_receipt() { | ||
| let allocation_id = receipt.message.allocation_id; | ||
| let signature = receipt.signature; |
There was a problem hiding this comment.
I don't understand how/why you're using the signature
There was a problem hiding this comment.
Signature is the best "unique id" for a specific receipt. It is unique for a given receipt + signer.
There was a problem hiding this comment.
I thought you wanted it to be unique per "SQL text" vs. unique per each query.
|
|
||
| // get agora model for the allocation_id | ||
| let mut cache = self.cost_model_cache.lock().unwrap(); | ||
| // on average, we'll have zero or one model |
There was a problem hiding this comment.
I'd expect that we can get more than 1 model in the case the model was recently updated, and we are still in the period where expect the query to be priced according to a previous model or the new one.
There was a problem hiding this comment.
indeed, we'll have more than one model when recently updated. But I expect that this is not that often. That's the reason for my comment. On average we'll have one model, or even zero if it's not set.
|
Having the cache in the indexer-service raises a small risk though. |
No description provided.