Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

indexer-agent: maxAllocationEpochs not being considered when identifiyng expired allocations #760

Closed
3 tasks done
tilacog opened this issue Sep 1, 2023 · 2 comments · May be fixed by #761
Closed
3 tasks done

indexer-agent: maxAllocationEpochs not being considered when identifiyng expired allocations #760

tilacog opened this issue Sep 1, 2023 · 2 comments · May be fixed by #761
Assignees
@tilacog
Labels
bug Something isn't working indexer-agent
Milestone
v0.20.23

Comments

@tilacog
Copy link
Contributor

tilacog commented Sep 1, 2023 •
edited

Multiple indexers have reported that the Indexer Agent will close and renew allocations one epoch after creation.

This means that the maxAllocationEpochs value provided by the Staking contract is not being considered when identifying expired allocations during the reconciliation loop.

Requirements
Beta Give feedback

Success Criteria
Beta Give feedback
@tilacog tilacog added the bug Something isn't working label Sep 1, 2023
@tilacog tilacog added this to the v0.20.23 milestone Sep 1, 2023
@tilacog tilacog self-assigned this Sep 1, 2023
@tilacog tilacog linked a pull request Sep 2, 2023 that will close this issue
agent: add logs to identifyExpiringAllocations function #761
Open
@tilacog
Copy link
Contributor Author

tilacog commented Sep 4, 2023

After a thorough review of user feedback suggesting a potential bug, we've found evidence indicating that the Agent is functioning as intended.

Logs show that maxAllocationEpochs value is being correctly fetched from the Staking contracts and being considered in the desired allocation lifetime calculation as designed.

@fordN
Copy link
Contributor

fordN commented Sep 15, 2023

Closing this issue. See comment above for explanation.

@fordN fordN closed this as completed Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tilacog tilacog

Labels
bug Something isn't working indexer-agent
Projects
Indexer Experience
Status: ❌ Closed
Milestone
v0.20.23
Development

Successfully merging a pull request may close this issue.

agent: add logs to identifyExpiringAllocations function graphprotocol/indexer
2 participants
@fordN @tilacog