Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

indexer-agent: Leave subgraph deployment assignment decisions to graph-node #867

Open
wants to merge 2 commits into
base: ford/deployments-use-pause-mechanism
Choose a base branch
from
Open

indexer-agent: Leave subgraph deployment assignment decisions to graph-node #867

wants to merge 2 commits into from

Conversation

fordN
Copy link
Contributor

@fordN fordN commented Mar 4, 2024

Hands off the assignments

Resolve #853

Changes

  • Use recently added subgraph_pause method to explicitly pause subgraph deployments rather than virtually pausing them by assigning to a non-existent index node
  • Remove index-node-ids startup parameter from indexer-agent
  • Never send an index-node-id param with subgraph_deploy requests, the receiving graph-node will make the index-node-id decision based on the graph-node.toml config file

@fordN fordN self-assigned this Mar 4, 2024
@fordN
Copy link
Contributor Author

fordN commented Mar 4, 2024

I wonder if we should include a migration script with this PR to reassign (to existing node id) and pause any subgraph deployments that are currently assigned to node_id = "removed".
@incrypto32 when upgrading the graph-node version to one that supports the subgraph_pause method is there already a data migration?

@fordN fordN requested review from abarmat and saihaj March 4, 2024 20:31
@fordN fordN added enhancement New feature or request indexer-agent labels Mar 4, 2024
@incrypto32
Copy link
Contributor

@fordN no there is no migration

@fordN fordN force-pushed the ford/no-deployment-assignments branch from a8a7326 to 861e840 Compare March 8, 2024 19:55
@fordN fordN changed the base branch from main to ford/deployments-use-pause-mechanism March 8, 2024 19:56
@fordN fordN force-pushed the ford/no-deployment-assignments branch from 861e840 to ba0a218 Compare March 8, 2024 19:59
@fordN fordN force-pushed the ford/deployments-use-pause-mechanism branch from db0c741 to e631b87 Compare March 8, 2024 20:05
@fordN
agent,common: Use new subgraph pausing mechanism
e80fd7e 
- Use subgraph_pause JSON-RPC method instead of subgraph_reassign, which
explicitly pauses subgraph instead of virtually pausing it by moving
it to a non-existent index node
@fordN
*: Remove all notion of node ids and subgraph node assignments
aed8c01 
- Leave subgraph deployment assignment decisions to the graph-node,
configurable in the graph-node.toml config file
@fordN fordN force-pushed the ford/no-deployment-assignments branch from ba0a218 to aed8c01 Compare March 8, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saihaj saihaj saihaj approved these changes

@abarmat abarmat Awaiting requested review from abarmat

Assignees

@fordN fordN

Labels
enhancement New feature or request indexer-agent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement: Indexer agent relies on graph-node to assign deployments to index-nodes
3 participants
@fordN @incrypto32 @saihaj