Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: WebSocket in the "Aborted" state cannot be closed. #561

Merged
merged 3 commits into from
Apr 20, 2021

Conversation

ricardo-salgado-tekever
Copy link
Contributor

WebSocket connection which are aborted for some reason - client drop, ou load balancer drop - the call to GraphQL.Server.Transports.WebSockets.WebSocketReaderPipeline.Complete will throw an Exception:
"System.Net.WebSockets.WebSocketException (%d): The WebSocket is in an invalid state ('Aborted') for this operation. Valid states are: 'Open, CloseReceived, CloseSent'"

Aborted connection therefore should not be "closed", as it is already closed.

@ricardo-salgado-tekever ricardo-salgado-tekever changed the title WebSocket in the "Aborted" state cannot be closed. Fix: WebSocket in the "Aborted" state cannot be closed. Apr 19, 2021
@sungam3r
Copy link
Member

@ricardo-salgado-tekever Looks reasonable. Please bump version in Directory.Build.props to 5.0.2 and I will publish a new release.

@sungam3r sungam3r added the bugfix Pull request that fixes a bug label Apr 19, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #561 (6561c4d) into master (2ab8faa) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #561      +/-   ##
==========================================
- Coverage   54.70%   54.63%   -0.08%     
==========================================
  Files          63       63              
  Lines        1497     1499       +2     
  Branches      151      151              
==========================================
  Hits          819      819              
- Misses        625      627       +2     
  Partials       53       53              
Impacted Files Coverage Δ
...ubscriptions.WebSockets/WebSocketReaderPipeline.cs 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ab8faa...6561c4d. Read the comment docs.

@ricardo-salgado-tekever
Copy link
Contributor Author

@ricardo-salgado-tekever Looks reasonable. Please bump version in Directory.Build.props to 5.0.2 and I will publish a new release.

Done!

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@sungam3r sungam3r merged commit c9aee7e into graphql-dotnet:master Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants