Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #355 handle null pointer lists #377

Merged
merged 1 commit into from Aug 21, 2018
Merged

Fixed #355 handle null pointer lists #377

merged 1 commit into from Aug 21, 2018

Conversation

koblas
Copy link
Contributor

@koblas koblas commented Aug 1, 2018

This fixed the previously reported bug dealing with optional lists.

Note: that it changes the unit test for union handling to resolve the now failing union test. @sfriedel, I couldn't find a good reference for the right answer, though since the test returns nil, it shouldn't necessarily be typed (IHMO), I couldn't find a good reference.

	union_interface_test.go:644: Unexpected result, Diff: [
		got: &{map[query:map[pet:<nil> named:<nil>]] []}
		want: &{map[query:map[pet:map[__typename:Cat] named:map[name:<nil> __typename:Cat]]] []}
		]

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 91.798% when pulling 6a8046d on koblas:master into 5c1be08 on graphql-go:master.

@koblas
Copy link
Contributor Author

koblas commented Aug 21, 2018

@chris-ramon Any chance of looking at this as well?

@chris-ramon
Copy link
Member

chris-ramon commented Aug 21, 2018

LGTM 👍 — thanks a lot @koblas 🚢

In regards the union test, we are fine updating it and to not return __typename for that particular use.

@chris-ramon chris-ramon merged commit ef7caf8 into graphql-go:master Aug 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants