Allow TypeReference as InputType with checks for non-null circular references #172
Comments
|
A bit here: #34. Needs more work to deal with the circular references validation. |
|
I implemented |
dminkovsky
added a commit
that referenced
this issue
Dec 20, 2016
#172 Allow TypeReference as InputType
|
Merged #204 |
GrigoryPtashko
added a commit
to GrigoryPtashko/graphql-java
that referenced
this issue
Dec 22, 2016
* upstream/master: Fix graphql-java#208: Cannot use custom execution strategies on mutations Parsing: ensure that keywords can be used as names Fixed grammar: type conditions in inline fragments are optional Fixed directive introspection GH graphql-java#196: Add tests for graphql-java#127 Added 'query' and 'mutation' as keywords in the grammar graphql-java#263 - make execution context thread safe by being mostly immutable and otherwise thread safe Fix graphql-java#244: Support for integer-valued ID fields Ensured type references are replaced regardless of type definition order Added a simple schema validation mechanism and a rule for recursive input types Added a test to ensure schema validation detects invalid recursive input types Added a test to ensure no dangling references exist Added a test to ensure input type references can not be used in place of output types Fixed DataFetcher example and typo in the readme Finish the GraphQL Schema parsing so it supports SchemaDefinition, DirectiveDefinition, and TypeExtensionDefinition type declarations. Initial take on adding GraphQL Schema parsing. change to fix open-jdk image instead java to fix build update to latest gradle version 3.2 ValuesResolver fixes for input object literals and variable values graphql-java#172 Allow TypeReference as InputType Reverted import to be in line with upstream Directive argument is no longer validated as field argument
GrigoryPtashko
added a commit
to GrigoryPtashko/graphql-java
that referenced
this issue
Apr 15, 2017
* upstream/master: Fiddle with language Clarify supported clients in README.md Increasing test coverage for FragmentsOnCompositeType Increasing test coverage for FieldsOnCorrectType.java Increasing test coverage for ArgumentsOfCorrectType.java Validate name Missing <I,O> on Coercing No starts in imports Spec validation for lone anonymouse operation Fix graphql-java#317: Coercing<T> should be Coercing<I, O> ? 105 - lenient numerical scalars graphql-java#308 - corrected readme graphql-java#308 - missing readme updates graphql-java#308 - males for a more fluent description of the schema Add jacoco plugin. It generates test coverage. import problem update related projects update related projects update links update related projects list, update link to contributors made DataFetchingEnvironment an interface. I appreciate that some one else did a PR on this but it had merge conflicts and I could not easily get the branch in play so it was easier to replicate the approach. graphql-java#269 - add an instrumentation callback for all the data retrieval Update README.md Add link to gitter.im chat room in README Fix README example error reported in graphql-java#295 Allows a ExecutionProvider to be provided by the caller Now allows you to specify a new "instrumentation" implementation when building the top level GraphQL level Renamed based on PR feedback fixed up tests. Still needs the new builder pattern new lines and formatting feedback about naming graphql-java#273 - updated readme and made compilable examples graphql-java#273 - merged master and now accounts for mutation strategy. Also updated the readme graphql-java#261 - PR feedback Issue 281: Spec allows for 'extensions' map in result but graphql-java does not. Updated README For v2.3.0 graphql-java#273 - updated readme to reflect generics graphql-java#273 - use generics where possible graphql-java#278 - consistent parameter ordering graphql-java#278 - merged in upstream master with tweaks graphql-java#278 - generate a unique id for a graphql query Fix graphql-java#208: Cannot use custom execution strategies on mutations Parsing: ensure that keywords can be used as names 273 - use builder pattern in GraphQL top level object Fixed grammar: type conditions in inline fragments are optional Fixed directive introspection GH graphql-java#196: Add tests for graphql-java#127 Added 'query' and 'mutation' as keywords in the grammar graphql-java#253 - oops - included code I used to help generate the hashcode / equals graphql-java#253 - hash code and equals on error helper graphql-java#263 - make execution context thread safe by being mostly immutable and otherwise thread safe graphql-java#269 - this adds parameter objects to Instrumentation SPI and hence makes it less brittle for future changes. Hmm missed test commit graphql-java#269 - this adds parameter objects to Instrumentation SPI and hence makes it less brittle for future changes graphql-java#269 - this adds instrumentation to the execution of the graphql query use getter edge as well allow customized prefix relay interfaces Fix graphql-java#244: Support for integer-valued ID fields Ensured type references are replaced regardless of type definition order Added a simple schema validation mechanism and a rule for recursive input types Added a test to ensure schema validation detects invalid recursive input types Added a test to ensure no dangling references exist Added a test to ensure input type references can not be used in place of output types Problem: passing input object as a resolved class doesn't work Fixed DataFetcher example and typo in the readme Finish the GraphQL Schema parsing so it supports SchemaDefinition, DirectiveDefinition, and TypeExtensionDefinition type declarations. Initial take on adding GraphQL Schema parsing. change to fix open-jdk image instead java to fix build update to latest gradle version 3.2 ValuesResolver fixes for input object literals and variable values graphql-java#172 Allow TypeReference as InputType Reverted import to be in line with upstream Directive argument is no longer validated as field argument PropertyDataFetcher supports AutoValue style classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As per graphql/graphql-spec#189 nullable circular references are legal in input types, thus
TypeReferenceshould be allowed as input.During schema building, when
TypeReferences are being replaced, a check needs to be put in place to prevent non-null circular references, though.The text was updated successfully, but these errors were encountered: