Methods in coercing can throw RunTimeExceptions

[lenin-jaganathan]

Describe the bug
The method contracts of Coercing allows for only Coercing*Exceptions to be thrown out of them. But, when the implementations only implement the deprecated versions of the methods using the latest graphql-java, and invoke non-deprecated versions of the APIs with any null values, there is a possibility for AssertionExceptions to be thrown.

Is this an expected behavior? And is it allowed to throw such validation exceptions?

To Reproduce
Use any Scalar from https://github.com/graphql-java/graphql-java-extended-scalars and invoke the non-deprecated API's with null values.

[bbakerman]

Can you tell me which methods this happens on.

I can see that graphql.scalar.GraphqlIntCoercing#valueToLiteral(java.lang.Object, graphql.GraphQLContext, java.util.Locale) will throw Asserts on not null and we can debate that but I could not see other methods doing this.

[lenin-jaganathan]

I guess all the methods in Coercing does throw an AssertionExceptions.

[github-actions]

Hello, this issue has been inactive for 60 days, so we're marking it as stale. If you would like to continue this discussion, please comment within the next 30 days or we'll close the issue.