Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPM 2.0.0 version has major code problems #375

Open
IvanSereginGitHub opened this issue Oct 11, 2023 · 1 comment
Open

NPM 2.0.0 version has major code problems #375

IvanSereginGitHub opened this issue Oct 11, 2023 · 1 comment

Comments

@IvanSereginGitHub
Copy link

render-voyager-page.js has window.addEventListener('load') with SYNC function trying to call ASYNC method (await response.json()). Not only that but await response.json() CANNOT be called like that since response is still a PROMISE, not a result object, therefore it should be either (await response).json() or it should be done SYNCHRONOUSLY.
And even after all that fixed manually, I still couldn't get past the "Loading..." because of "GraphQLVoyager.init is not a function".

Didn't test previous versions, so can't say anything about them. Please fix NPM 2.0.0 version, considering those problems - I doubt that it was tested at all...

@mnlbox
Copy link

mnlbox commented Oct 19, 2023

Related: #372

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants