Propagate arguments of relay.NodeField to Field #1036
Merged
+14
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdiam
requested review from
dan98765,
ekampf,
jkimbo and
ProjectCheshire
as code owners
tdiam
force-pushed
the
graphene-nodefield-issue
branch
from
dac3d42 to
675743f
Compare
tdiam
force-pushed
the
graphene-nodefield-issue
branch
from
17820fc to
8746230
Compare
chason
suggested changes
Jul 18, 2019
ProjectCheshire
approved these changes
Sep 25, 2019
|
Could we also merge this in the v2 branch? Some librairies (like graphene-django) are still relying on the v2... I created a pull request to cherry pick this into the v2 branch: #1307 |
tcleonard
pushed a commit
to loft-orbital/graphene
that referenced
this pull request
Jan 26, 2021
* Propagate name, deprecation_reason arguments of relay.NodeField to Field * Allow custom description in Node.Field and move ID description to ID argument * Add test for Node.Field with custom name * Add tests for description, deprecation_reason arguments of NodeField * Pass all kwargs from NodeField to Field
ekampf
pushed a commit
that referenced
this pull request
Apr 23, 2021
* Propagate name, deprecation_reason arguments of relay.NodeField to Field * Allow custom description in Node.Field and move ID description to ID argument * Add test for Node.Field with custom name * Add tests for description, deprecation_reason arguments of NodeField * Pass all kwargs from NodeField to Field Co-authored-by: Theodore Diamantidis <diamaltho@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1035
Question: Should all
**kwargsfromNodeField's constructor be propagated or should there be any check to ensure the field gets no arguments other thanid?Edit 1: I also moved the "The ID of the object" description to the ID argument instead of the whole Field, since it seemed more appropriate, and included
descriptionin the propagated arguments.